added new fields to metadata #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ddey2
commented
Dec 12, 2022
ddey2
commented
- Added new fields to metadata in elasticsearch
- Updated fields in metadata index in elasticsearch on updating file/dataset in Clowder GUI
Member
Author
|
will address the backend lint failure on next commit along with other feedbacks |
this should fix tests
Contributor
I went ahead and ran pipenv run black app and pushed since it was a simple fix. Should finish review on this soon. |
Member
Author
|
Thanks @tcnichol |
tcnichol
approved these changes
Dec 14, 2022
Contributor
tcnichol
left a comment
tcnichol
left a comment
There was a problem hiding this comment.
This one works and all tests are passing so marking approved.
longshuicy
approved these changes
Dec 15, 2022
lmarini
requested changes
Jan 12, 2023
Member
lmarini
left a comment
lmarini
left a comment
There was a problem hiding this comment.
Just a small suggestion about duplicate code.
lmarini
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.