202 file breadcrumb folders not in breadcrumb for files fixed #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmarini
requested changes
Nov 21, 2022
Member
lmarini
left a comment
lmarini
left a comment
There was a problem hiding this comment.
Works great when I navigate to the file from the folder. When I reload the file page it's still missing.
longshuicy
approved these changes
Nov 21, 2022
lmarini
approved these changes
Nov 21, 2022
Contributor
Author
|
Checked. The breadcrumb is right after reload now. Also checked with subfolder. However, navigation seems broken after you upload file to folder and it redirects. |
…ly folder was not passed in.
# Conflicts: # frontend/src/components/datasets/Dataset.tsx # frontend/src/components/files/File.tsx
…show-folders' into 212-file-page-breadcrumb-doesnt-show-folders # Conflicts: # frontend/src/components/files/File.tsx
longshuicy
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixed. The file page was getting folderpath from dataset.state instead of folder.state.