Skip to content

142 remove url encoding when creating dataset and files #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lmarini merged 2 commits into from
Nov 14, 2022
Merged

142 remove url encoding when creating dataset and files #189

lmarini merged 2 commits into from
Nov 14, 2022

Conversation

@longshuicy
Copy link
Member

@longshuicy longshuicy commented Nov 10, 2022

fix two encoding related issues:

  1. now upload a file with empty space in the file name would look correct

image

  1. tag is correctly used to highlight the search result

image

@longshuicy longshuicy linked an issue Nov 10, 2022 that may be closed by this pull request
remove URL encoding when creating dataset and files #142
Closed
@longshuicy longshuicy marked this pull request as ready for review November 10, 2022 19:36
@lmarini lmarini mentioned this pull request Nov 14, 2022
Open
@lmarini lmarini merged commit 5952507 into main Nov 14, 2022
@lmarini lmarini deleted the 142-remove-url-encoding-when-creating-dataset-and-files branch November 14, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmarini lmarini lmarini approved these changes

@ddey2 ddey2 ddey2 approved these changes

@arunapa arunapa Awaiting requested review from arunapa

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

remove URL encoding when creating dataset and files

4 participants

@longshuicy @lmarini @ddey2