Skip to content

Conversation

@tcnichol
Copy link
Contributor

@tcnichol tcnichol commented Nov 3, 2022

No description provided.

working on adding submit dataset to extractor
also adding a sample extractor_info.json file for registration purposes
…-extractor-submit-add-submit-dataset

# Conflicts:
#	backend/app/routers/datasets.py
beginning of adding listener/extractor to front end
# Conflicts:
#	backend/app/models/extractors.py
#	backend/app/models/feeds.py
#	backend/app/models/listeners.py
#	backend/app/models/search.py
#	backend/app/rabbitmq/listeners.py
#	backend/app/routers/datasets.py
#	backend/app/routers/feeds.py
#	backend/app/routers/files.py
#	backend/app/routers/listeners.py
#	backend/app/tests/test_extractors.py
#	frontend/src/openapi/v2/services/DatasetsService.ts
@tcnichol tcnichol marked this pull request as ready for review November 14, 2022 18:47
@tcnichol tcnichol requested a review from max-zilla as a code owner November 14, 2022 18:47
@tcnichol
Copy link
Contributor Author

tcnichol commented Nov 14, 2022

In order to test this, you will need to use the pyclowder from this pull request:
clowder-framework/pyclowder#51
to register extractors, run the /app/rabbitmq/heartbeat_listener_sync.py and then run an extractor. That will register the extractor.

Files and datasets can be submitted.

This was linked to issues Nov 14, 2022
@longshuicy longshuicy requested a review from arunapa November 28, 2022 16:33
# Conflicts:
#	backend/app/routers/metadata_files.py
#	frontend/src/components/Explore.tsx
#	frontend/src/components/Layout.tsx
#	frontend/src/components/datasets/Dataset.tsx
#	frontend/src/components/files/File.tsx
#	frontend/src/openapi/v2/services/DatasetsService.ts
@tcnichol tcnichol linked an issue Dec 5, 2022 that may be closed by this pull request
@tcnichol
Copy link
Contributor Author

tcnichol commented Dec 6, 2022

Instructions on how to test.

This pull request depends on this pull request in pyclowder.

clowder-framework/pyclowder#51

Without using that pyclowder, the extractors will not work with clowder v2.

To register an extractor:

create a new configuration to run the script:

/app/rabbitmq/heartbeat_listener_sync.py

I had issues with imports from clowder2, but if I opened it up in /backend in PyCharm I was able to run it without issues.

While that is running, start an extractor (example - wordcount). You will then see that it is registered in the console.

After that point, you don't need to run the heartbeat monitor.

If you run clowder, you can see the extractors/listeners under the page:

localhost:3000/listeners

You can submit a file or dataset to an extractor. There is a button for each of them for EXTRACT.

Right now the GUI is pretty bad, and it's not possible to support parameters through the GUI even though the backend routes support them.

Also, every now and then pyclowder will throw an error 'host is empty this is bad.' Restarting everything should fix that. I will make that a separate issue.

Additionally, right now the metadata for the extractor is not visible under the 'metadata' tab. Looking for input as to how to display it and where.

Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we merge this as it is and work on top of that?


// parameters
const search = useLocation().search;
const {datasetId} = useParams<{ datasetId?: string }>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

	let [searchParams, setSearchParams] = useSearchParams();
	const datasetId = searchParams.get("datasetId");
	const fileId = searchParams.get("fileId");

@lmarini
Copy link
Member

lmarini commented Dec 12, 2022

can we merge this as it is and work on top of that?

@longshuicy go for it, please squash

@longshuicy longshuicy merged commit 66c64d2 into main Dec 12, 2022
@max-zilla max-zilla deleted the 170-add-extractor-to-gui branch July 20, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add extractor to GUI basic button on front end for extractor submission submit extractor dataset backend submit extractor file backend

5 participants