Skip to content

Conversation

@longshuicy
Copy link
Member

  • Toggle between Lucene query string and normal facet search
  • Move error boundary to only wrap around the results part
  • When string incomplete showing some hints and error message from elasticsearch

image

image

image

@longshuicy longshuicy linked an issue Nov 3, 2022 that may be closed by this pull request
@ddey2 ddey2 self-requested a review November 3, 2022 16:49
@ddey2
Copy link
Member

ddey2 commented Nov 3, 2022

I am reviewing your PR. SOme things I noted are:

  1. I searched for 'dataset' in searchbox and the same results appear multiple times. I checked the elasticsearch index and there are only 4 entries for datasets. One reason could be, they had been updated and the search result show all of the combinations. Do we want that?

Screen Shot 2022-11-03 at 11 56 11 AM

  1. Not able to see 'Author' field in facet

Screen Shot 2022-11-03 at 11 59 45 AM

  1. I typed 'author:ddye2' and it showed "No suggestions". It gave me results upon hitting 'ENTER'. Also, I just uploaded a file, but can't seem to find it in results. I thought we are searching both file and datasets.

Screen Shot 2022-11-03 at 12 02 59 PM

@longshuicy
Copy link
Member Author

2. Not able to see 'Author' field in facet

Luigi also had the same issue. Did you try clear all of your elasticsearch database and start from scratch? If yes, I will open an issue to investigate this

@longshuicy
Copy link
Member Author

3. I typed 'author:ddye2' and it showed "No suggestions". It gave me results upon hitting 'ENTER'. Also, I just uploaded a file, but can't seem to find it in results. I thought we are searching both file and datasets.

Yes we are searching both file and datasets.

  1. Looking at screenshot you are not switching to the query string search? Facet search probably didn't understand "author:ddye2" this syntax.

  2. for file it's "creator": {"type": "keyword"}, according to the config. Author is only for dataset. We might want to think about unify those field name.

@longshuicy
Copy link
Member Author

  1. I searched for 'dataset' in searchbox and the same results appear multiple times. I checked the elasticsearch index and there are only 4 entries for datasets. One reason could be, they had been updated and the search result show all of the combinations. Do we want that?

I also noticed that... it has weird related to that too... i opened an issue to investigate that further #185

@ddey2
Copy link
Member

ddey2 commented Nov 4, 2022

Thanks for clarification on no3. I will clear my cache and again check for no.2

@lmarini lmarini merged commit bd3dfa4 into main Nov 7, 2022
@lmarini lmarini deleted the 175-search-box-syntax branch November 7, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search box syntax

4 participants