Skip to content

Conversation

@ddey2
Copy link
Member

@ddey2 ddey2 commented Oct 13, 2022

No description provided.

@ddey2 ddey2 linked an issue Oct 13, 2022 that may be closed by this pull request
Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just left one comment about route;
because in reactivesearch you have to specify a baseapp name. so it has to be something like /xxxx/_msearch.

The Documentation suggesting use a comma separate indexes so in this case it's /file,dataset/_msearch

@longshuicy
Copy link
Member

In addition, could we add more fields to file
I would definitely need

dataset_id: PyObjectId
folder_id: Optional[PyObjectId]

it would be also nice to have

bytes: int = 0
content_type: str = "N/A"

@ddey2
Copy link
Member Author

ddey2 commented Oct 14, 2022

Sure. I can add those fields. Also, if you need anything else, let me know. I will create a separate PR for adding the fields.

@longshuicy
Copy link
Member

Sure. I can add those fields. Also, if you need anything else, let me know. I will create a separate PR for adding the fields.

Actually do you mind I create those additional fields in the PR i'm working on? that might be more efficient

@longshuicy longshuicy merged commit 3d413d5 into main Oct 17, 2022
@ddey2
Copy link
Member Author

ddey2 commented Oct 17, 2022

@longshuicy Feel free to add those fields.

@max-zilla max-zilla deleted the 137-create-endpoint-to-search-both-dataset-and-file branch July 20, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Create endpoint to search both dataset and file

3 participants