122 minify keycloak realm json so kubernetes clusters have easier way to load it #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robkooper
approved these changes
Oct 3, 2022
Member
robkooper
left a comment
robkooper
left a comment
There was a problem hiding this comment.
I think this cleans it up a bunch, just wondering if we can remove more in the client and identityProviders sections. I think most of those are default values as well
| ] | ||
| }, | ||
| { | ||
| "id": "9d3fa7e0-6aa2-45c1-865d-4eee673eb6bf", |
Member
There was a problem hiding this comment.
do we need all the default values here? or can we remove more?
…clusters-have-easier-way-to-load-it
longshuicy
changed the title
lmarini
approved these changes
Nov 7, 2022
lmarini
deleted the
122-minify-keycloak-realmjson-so-kubernetes-clusters-have-easier-way-to-load-it
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keep both minified and original keycloak config
I tested the
clowder-realm-dev.jsonon my local machine by just doingsh docker-dev.sh up; it's using the docker-compose.dev.yaml where mount this json volume... seems ok to me? But not sure is there other ways I can test this