When adding metadata, sometimes two instances of it would show up aft… #1201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er adding, but only one was on the server (refreshing showed one). Combining the useEffect statements seems to have fixed that. At some point we should remove the complex if logic included with the jsx. We might want to have separate components for dataset and files and a common one for the actual entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er adding, but
only one was on the server (refreshing showed one). Combining the useEffect statements seems to have fixed that.
At some point we should remove the complex if logic included with the jsx. We might want to have separate components for dataset and files and a common one for the actual entries.
I am actually not sure this fixes the problem. Leaving it open while I try to figure things out.
While this doesn't solve the problem (there is some kind of race condition), it does clean up the code. Marking it ready.