Skip to content

Conversation

@longshuicy
Copy link
Member

@longshuicy longshuicy commented Jul 2, 2024

To Test:

image

@longshuicy longshuicy requested review from ddey2, lmarini and tcnichol July 2, 2024 22:00
@longshuicy longshuicy linked an issue Jul 2, 2024 that may be closed by this pull request
@longshuicy longshuicy marked this pull request as ready for review July 2, 2024 22:00
@longshuicy longshuicy self-assigned this Jul 2, 2024
@tcnichol
Copy link
Contributor

tcnichol commented Jul 4, 2024

@longshuicy I am testing this branch but noticing that on my previews, I am missing the 'learn more' or 'share link.' I just have the right lower corner box that enlarges the visualization.

This is the same for .png or .jpg files. I also ran the image extractor, and I still don't see the 'learn more' or 'share link.'

I did rm -rf node_modules and ran npm install again, as well as deleting volumes. Let me know if there's some reason I am not seeing this.

@ddey2
Copy link
Member

ddey2 commented Jul 8, 2024

I am noticing the same thing as @tcnichol
The expand button works great

@longshuicy
Copy link
Member Author

I am noticing the same thing as @tcnichol The expand button works great

@tcnichol @ddey2 that's due to the "raw bytes" preview does not have any visualization information.
To show the Learn More you have to submit an image to the "Preview Extractor".

@lmarini lmarini merged commit 120097d into main Jul 18, 2024
@lmarini lmarini deleted the 1092-enhanced-visualization-layout branch July 18, 2024 14:23
@longshuicy longshuicy linked an issue Aug 1, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhanced visualization layout Add expand button to visualization card

5 participants