removing left dividers #1133
Merged
removing left dividers #1133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longshuicy
requested changes
Jul 2, 2024
Member
longshuicy
left a comment
longshuicy
left a comment
There was a problem hiding this comment.
Could we just remove the divider altogether? I don't think it will look too bad without it. Thoughts?
Contributor
Author
|
@longshuicy i have removed the left dividers and fixed the spacing. Here is a screenshot of it for logged in (not read only) users |
Contributor
Author
|
Here is the left drawer for the read only user: |
ddey2
approved these changes
Jul 8, 2024
longshuicy
approved these changes
Jul 11, 2024
longshuicy
deleted the
1097-divider-between-items-on-the-side-tab-need-to-be-removed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was that if you were a read only user, you saw 2 dividers that were empty on the left.
Now you don't see those 2 dividers, but the 'search' section looks larger than it should.
Not sure how to fix it, so this is draft.
