added check for rendering step1 #1116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcnichol
approved these changes
Jun 21, 2024
Contributor
tcnichol
left a comment
tcnichol
left a comment
There was a problem hiding this comment.
This looks good. With no metadata definitions, this does not appear for files.
longshuicy
reviewed
Jun 24, 2024
… has a required field and also hide back button if there is no step1
longshuicy
reviewed
Jun 28, 2024
Member
longshuicy
left a comment
longshuicy
left a comment
There was a problem hiding this comment.
Could you check now even if metadata is required it's not showing the first step. See screenshot:
Member
Author
|
@longshuicy It will not show up as the required metadata has no required field. |
Member
Ah my bad. I understand now. Approved. |
longshuicy
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current UI:
