Skip to content

Conversation

@tcnichol
Copy link
Contributor

This is draft, I think I found a fix but my pre commit is still acting up.

@tcnichol tcnichol linked an issue Jun 14, 2024 that may be closed by this pull request
@tcnichol tcnichol requested review from Vismayak, ddey2 and lmarini June 14, 2024 20:43
@tcnichol
Copy link
Contributor Author

I think something is messed up here. I only wanted changes in Group component, I reverted changes in the other one, but it still shows changes.
Draft till I figure this out.

@tcnichol tcnichol marked this pull request as ready for review June 15, 2024 21:36
@tcnichol tcnichol requested a review from longshuicy as a code owner June 15, 2024 21:36
@longshuicy longshuicy marked this pull request as draft June 24, 2024 14:35
@longshuicy longshuicy changed the title 1082 group is not updated after delete user WIP: 1082 group is not updated after delete user Jun 24, 2024
@longshuicy
Copy link
Member

I switched this to draft according to your comments; if this is ready feel free to switch it back. Thanks!

@tcnichol tcnichol marked this pull request as ready for review June 28, 2024 15:36
@longshuicy longshuicy changed the title WIP: 1082 group is not updated after delete user 1082 group is not updated after delete user Jun 28, 2024
@lmarini lmarini added this to the v2.0-beta-3 milestone Jun 28, 2024
@ddey2
Copy link
Member

ddey2 commented Jun 28, 2024

@tcnichol I see this

Screenshot 2024-06-28 at 12 26 33 PM

Copy link
Member

@ddey2 ddey2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tcnichol You might want to merge main to resolve the above error.

Also, it doesn't work. I deleted user but it doesn't update it on the page unless you refresh it.

@tcnichol
Copy link
Contributor Author

@tcnichol You might want to merge main to resolve the above error.

Also, it doesn't work. I deleted user but it doesn't update it on the page unless you refresh it.

Can you try to delete the node_modules file and then do npm install again? When I switched to another branch and back, it wasn't working until I did npm install again.

Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR works but it seems to get rid of a few existing functionality.
Also a little explanation on what's the culprit of the issue and what's the fix would be greatly appreciated!

tcnichol added 2 commits June 28, 2024 14:58
useEffect hook needed to depend on admin mode and groupAbout, so it will change the group members when groupAbout changes.
@tcnichol
Copy link
Contributor Author

@longshuicy

I went back and reverted all of these files to main, and then just made the change necessary to make this work. I'm not sure why it got changed so much.

The basic thing was the useEffect hook needed to depend on groupAbout, so it would populate the group members correctly when groupAbout changed after a user was deleted from the group. Now it updates right for delete and add, and that should be the only change.

@longshuicy
Copy link
Member

Thanks for the explanation. Deletion works well now.

However when I try to edit the role of any user, it wouldn't allow me to select any of those selection
image

@tcnichol tcnichol requested review from ddey2 and longshuicy July 1, 2024 15:08
@longshuicy longshuicy merged commit 570c716 into main Jul 1, 2024
@longshuicy longshuicy deleted the 1082-group-is-not-updated-after-delete-user branch July 1, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

group is not updated after delete user

5 participants