-
Notifications
You must be signed in to change notification settings - Fork 6
1082 group is not updated after delete user #1111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think something is messed up here. I only wanted changes in Group component, I reverted changes in the other one, but it still shows changes. |
|
I switched this to draft according to your comments; if this is ready feel free to switch it back. Thanks! |
|
@tcnichol I see this
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tcnichol You might want to merge main to resolve the above error.
Also, it doesn't work. I deleted user but it doesn't update it on the page unless you refresh it.
Can you try to delete the node_modules file and then do npm install again? When I switched to another branch and back, it wasn't working until I did npm install again. |
longshuicy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR works but it seems to get rid of a few existing functionality.
Also a little explanation on what's the culprit of the issue and what's the fix would be greatly appreciated!
useEffect hook needed to depend on admin mode and groupAbout, so it will change the group members when groupAbout changes.
|
I went back and reverted all of these files to main, and then just made the change necessary to make this work. I'm not sure why it got changed so much. The basic thing was the useEffect hook needed to depend on groupAbout, so it would populate the group members correctly when groupAbout changed after a user was deleted from the group. Now it updates right for delete and add, and that should be the only change. |


This is draft, I think I found a fix but my pre commit is still acting up.