-
Notifications
You must be signed in to change notification settings - Fork 6
1098 superamin messes up dataset pagination #1104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lmarini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think this fixes the listed datasets, but the pagination controls seem to have issues. The number of pages is updated, but I don't think a page is selected
- What are the changes to
open.jsonfor?
I think open.json got changed when I ran the pre-commit hooks. I can undo that. Will check page pagination. |
longshuicy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Admin mode pagination seems to be fixed.
However, in admin mode when I try to switch to "my dataset" tab, it doesn't allow me to flip pages. When I check the network tab I see double calls to the backend: one with mine=true, the other with mine=false.
This might related to the logic you added, when adminMode = True you list the dataset with mine=false
if (adminMode) {
listDatasets(0, limit, false);
This part.
ddey2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
longshuicy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working correctly now. Also it resovled this issue #1123
ddey2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfect.
remove not used inline comment


A fix that has worked for me is to make sure that mine=false when using superadmin mode.