Added indexing for dataset and added documentation #89 #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dipannita Dey <[email protected]>
ddey2
requested review from
lmarini,
longshuicy and
max-zilla
as code owners
Closed
lmarini
requested changes
Oct 5, 2022
backend/app/main.py
Outdated
| es = connect_elasticsearch() | ||
| create_index(es, "file", settings.file_settings) | ||
| create_index(es, "dataset", settings.file_settings) | ||
| pass |
Member
There was a problem hiding this comment.
I think we don't need pass anymore if the function as a body.
longshuicy
reviewed
Oct 5, 2022
…set if any of the service is not available
Member
|
Backend is failing to build. Rerunning. |
# Conflicts: # docs/source/elasticsearch.md # docs/source/img/elasticsearch1.png
* install reactivesearch * enable cors * cors; correct usage of reactivesearch * correctly configure reactive search * basic demo of reactivesearch * tmp * Added indexing for dataset and added documentation Signed-off-by: Dipannita Dey <[email protected]> * fixing black tets * Fixed doc format and added endpoint to expose search * add search endponit to router * search_index see hits but cannot return it successfully yet * proxy is working * add authentication * split into search file and search dataset * add route protection * keyword field cannot be directly query * Fixed elasticsearch pytest to use msearch. * switch back to keyword for filtering capability * typo Signed-off-by: Dipannita Dey <[email protected]> Co-authored-by: Dipannita Dey <[email protected]> Co-authored-by: Luigi Marini <[email protected]>
longshuicy
approved these changes
Oct 10, 2022
lmarini
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dipannita Dey [email protected]