users unable to search files #1076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should save some time as often every file needs to be indexed after the dataset
Contributor
Author
|
I'm converting to draft again because some issues are coming up with groups. Adding and removing members from groups seems to mean that some users who are in a group that has access to a file or dataset will not get it in search results. |
when adding a user to a group, elasticsearch is not updated when adding a group, if there were no read only users and empty list was inserted into the index
fixing indexing for files
Contributor
Author
|
Important Note: I cannot get the shellcheck pre-commit hook to run on my machine. So far I have found no solution - I can install it via brew but if my pre-commit config is not the same as the one in the github repo, it rejects the commit. So if someone else can please run it as part of the review, thank you very much. This should be ready to review now. |
longshuicy
reviewed
Jun 24, 2024
longshuicy
reviewed
Jun 24, 2024
Member
longshuicy
left a comment
longshuicy
left a comment
There was a problem hiding this comment.
Could you merge in the latest main to fix the pytest failure? Thanks!
Member
|
I see this. Could you please check? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I change the name here since the bug affected more than just read only users.
If a user who is not the owner of a dataset searched for files, they would not find files in the dataset.
This is because the user_ids were not updated in the elasticsearch entries for the files.
To fix this, I added a method index_dataset_files which is called after datasets are updated and indexed.
I also checked and a user that is part of a group will find files in the group. Ready for review.