Skip to content

Conversation

@lmarini
Copy link
Member

@lmarini lmarini commented Sep 26, 2022

Rearranged directories so that docs, keycloak, scripts are not in backend anymore and
are easier to find. Moved some files around as well. Top level directories are now:
/.github
/backend
/docker
/docs
/frontend
/scripts

…kend anymore and

are easier to find. Moved some files around as well. Top level directories are now:
/.github
/backend
/docker
/docs
/frontend
/scripts
# Conflicts:
#	docker-compose.dev.yml
#	docker-compose.yml
@longshuicy
Copy link
Member

I'm wondering is it possible to change "keycloak" to "clowder_keycloak"; as well as "keycloak.py" to "clowder_keycloak.py" to avoid confusion when important and potential naming collision? We are installing the python keycloak package it's also named "keycloak".

But ^ this doesn't break anything so far so it's not very necessary at least for now.

@longshuicy
Copy link
Member

PR looks good. Approving.

@lmarini
Copy link
Member Author

lmarini commented Sep 27, 2022

I'm wondering is it possible to change "keycloak" to "clowder_keycloak"; as well as "keycloak.py" to "clowder_keycloak.py" to avoid confusion when important and potential naming collision? We are installing the python keycloak package it's also named "keycloak".

But ^ this doesn't break anything so far so it's not very necessary at least for now.

The /scripts/keylcloak folder? It's not a python folder so it shouldn't be an issue?

Or the /backend/app/routers/keycloak.py module? maybe keycloak_routes.py? or kc.py? I would rather avoid repeating the word clowder.

@longshuicy
Copy link
Member

I'm wondering is it possible to change "keycloak" to "clowder_keycloak"; as well as "keycloak.py" to "clowder_keycloak.py" to avoid confusion when important and potential naming collision? We are installing the python keycloak package it's also named "keycloak".
But ^ this doesn't break anything so far so it's not very necessary at least for now.

The /scripts/keylcloak folder? It's not a python folder so it shouldn't be an issue?

Or the /backend/app/routers/keycloak.py module? maybe keycloak_routes.py? or kc.py? I would rather avoid repeating the word clowder.

maybe just keycloak.py to keycloak_routes.py

@lmarini lmarini merged commit c5a01df into main Sep 30, 2022
@lmarini lmarini deleted the move_docs_to_root branch September 30, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants