Skip to content

breadcrumb in the public components point to the wrong frontend routes #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lmarini merged 1 commit into from
May 13, 2024
Merged

breadcrumb in the public components point to the wrong frontend routes #1045

lmarini merged 1 commit into from
May 13, 2024

Conversation

@longshuicy
Copy link
Member

@longshuicy longshuicy commented May 9, 2024 •
edited
Loading

To test:

  1. create a dataset with nested folders and files
  2. change its status to public
  3. logout
  4. explore this public datasets's folder and file and click their breadcrumbs to see if it leads to the right location

e.g.
image
image

@longshuicy longshuicy linked an issue May 9, 2024 that may be closed by this pull request
Public breadcrumb point to wrong urls #1028
Closed
@lmarini lmarini merged commit 6660a51 into main May 13, 2024
@lmarini lmarini deleted the 1028-public-breadcrumb-point-to-wrong-urls branch May 13, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmarini lmarini lmarini approved these changes

@Vismayak Vismayak Awaiting requested review from Vismayak

@ddey2 ddey2 Awaiting requested review from ddey2

@tcnichol tcnichol Awaiting requested review from tcnichol

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Public breadcrumb point to wrong urls

3 participants

@longshuicy @lmarini