-
Notifications
You must be signed in to change notification settings - Fork 6
Enable/disable listeners #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable/disable listeners #1022
Conversation
tcnichol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and everything works. Marking approved.
|
Tested and working, approved! |
lmarini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides some minor comments there is a couple of high level issues I noticed:
- Anyone can click on the extractor link, but if you are not in admin mode, nothing shows in the list. Maybe we can have a message for now. Or not show the link in the menu unless you are in admin. I am not sure.
- Once I went into admin, I clicked on two extractors, but when I go to the dataset submission page, three show active. I countinued to click and the lists on dataset page and file page of enabled extractors are off from the main page.
Thanks!
Hi Luigi,
|
|
May 16th meeting -
|
lmarini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for making those changes.


Addressed:
To test:
Adding some screenshots for reference.





