Skip to content

Conversation

@Benbentwo
Copy link
Member

@Benbentwo Benbentwo commented Jul 2, 2025

what

  • Update AWS SSO docs.
    • Update Microsoft since it changed to be Entra
    • Removing wording for "handoff to cloudposse" which was from an older period of our reference architecture
    • Fixes issue with code block on identity/deploy.mdx
Other Bugfix

Before
CleanShot 2025-07-02 at 12 42 34

After
CleanShot 2025-07-02 at 12 42 22

why

  • More Clear instructions hopefully

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates AWS SSO documentation to reflect Microsoft’s rebranding to Entra ID, removes outdated “handoff to CloudPosse” wording, and fixes an MDX code block error in the deploy guide.

  • Enhance StepNumber component with an overrideNumber prop.
  • Rename Microsoft 365/Office 365 references to Microsoft Entra ID across multiple docs.
  • Correct MDX tag placement in deploy.mdx and improve AWS SSO guide with new Step markup.

Reviewed Changes

Copilot reviewed 6 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/components/StepNumber/index.js Added overrideNumber prop to allow manual step numbering.
docs/layers/identity/optional/optional.mdx Introduced a new “Optional” components landing page.
docs/layers/identity/optional/aws-saml.mdx Shortened “Identity Provider” to “IdP” and updated Microsoft tab.
docs/layers/identity/design-decisions/decide-on-idp.mdx Renamed Office 365 label to Microsoft Entra ID for consistency.
docs/layers/identity/deploy.mdx Fixed misplaced </Note> tag so AtmosWorkflow isn’t nested.
docs/layers/identity/aws-sso.mdx Overhauled Microsoft section with Entra ID steps and StepNumber.
Comments suppressed due to low confidence (3)

docs/layers/identity/optional/aws-saml.mdx:55

  • The link label mentions Microsoft Entra ID, but the URL path still references office-365. Consider updating the slug to match Entra ID for consistency.
        The setup for Microsoft Entra ID (formerly AzureAD) has a few issues that we've encountered. Please follow our [documentation on Microsoft Entra ID](/layers/identity/tutorials/how-to-setup-saml-login-to-aws-from-office-365/) to get the metadata file.

docs/layers/identity/aws-sso.mdx:177

  • The heading level for 'Automatic Provisioning' was changed from ### to ##, which may disrupt the document hierarchy. Consider using ### to match the surrounding sections.
    ## Automatic Provisioning

docs/layers/identity/deploy.mdx:88

  • The closing </Note> tag is indented differently than the opening <Note> tag. Align indentation to improve readability.
    </Note>

@Benbentwo Benbentwo merged commit def81c0 into master Jul 9, 2025
2 checks passed
@Benbentwo Benbentwo deleted the feature/dev-3495-update-aws-sso-documentation-for-o365-integration branch July 9, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants