Runs on Docs #782
Merged
Runs on Docs #782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
… with example configs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new “Runs On” self-hosted runners guide and refines the File component’s styling and implementation.
- Introduces a detailed MDX guide for setting up and using self-hosted GitHub Actions runners.
- Adds CSS rules to support line numbering, tabs, and viewport styling in the
Filecomponent. - Implements a basic React
Filecomponent (TSX) and removes the deprecatedEmbedFileloader.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/File/index.tsx | New React File component rendering a title tab and content viewport |
| src/components/File/index.css | Styles for line numbers, tabs, and viewport in code display |
| src/components/EmbedFile/index.js | Removed unused EmbedFile component |
| docs/layers/github-actions/runs-on.mdx | Added “Runs On” guide with setup steps, examples, and troubleshooting |
| .nvmrc | Downgraded Node.js version from v21.7.3 to v20.12.0 |
Comments suppressed due to low confidence (2)
.nvmrc:1
- [nitpick] Ensure this Node.js version aligns with your
package.jsonengines field and any CI configurations to avoid version mismatches.
v20.12.0
osterman
reviewed
Jul 1, 2025
osterman
reviewed
Jul 2, 2025
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]>
milldr
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes across different areas of the codebase, including dependency updates, documentation enhancements, and component refactoring. The key highlights are the downgrade of the Node.js version, the addition of a new documentation guide for self-hosted runners, and the complete refactoring of the
EmbedFilecomponent to improve modularity and styling.Dependency Updates:
.nvmrc: Downgraded Node.js version fromv21.7.3tov20.12.0to align with compatibility requirements.Documentation Enhancements:
docs/layers/github-actions/runs-on.mdx: Added a comprehensive guide on setting up and managing self-hosted runners, including step-by-step instructions, configuration examples, and troubleshooting tips.Component Refactoring:
src/components/EmbedFile/index.js: Removed theEmbedFilecomponent, which dynamically loaded and displayed file content, to simplify the codebase and improve maintainability.src/components/File/index.tsx: Introduced a newFilecomponent in TypeScript, encapsulating file display functionality with improved structure and modularity.src/components/File/index.css: Added new styles for theFilecomponent, including enhancements for line numbering, tabs, and viewport design, with support for light and dark themes.