Skip to content

Conversation

@radito3
Copy link
Contributor

@radito3 radito3 commented Jan 22, 2021

Fixes #1087

@radito3
Copy link
Contributor Author

radito3 commented Jun 1, 2021

Hi @dmikusa-pivotal ,
I have opened the PR in January and am still waiting for the contribution to be accepted in the repository. I would like to ask what else do I have to do for this PR the be accepted?

@dmikusa
Copy link
Contributor

dmikusa commented Jun 3, 2021

Hi, sorry for the delay. I took a quick glance and the main thing that jumps out is that there do not appear to be any integration tests. Those would be required before I can merge anything.

It does require full admin access to a CF installation. If you do not have access to one, you can run one locally using bosh-deployment & cf-deployment & Virtualbox.

  1. See Install Section to install Bosh.
  2. Follow the deployment guide to get CF installed. I think you can skip to step 4, since you're installing locally. Definitely read this section before you get started though. It has some info for running locally.

Before you start the tests, I would recommend taking a snapshot of the VMs in the environment. That way you can quickly restore back to the initial state (tests should clean up after themselves, but this gives you another way to refresh your env).

If you are unable to do that or unable to write the integration tests, I can write them but I cannot promise priority to that work so it will be much quicker to merge this PR if you are able to provide them. Thanks

@dmikusa dmikusa added client triaged Initial triage of issue has been performed labels Jun 3, 2021
@radito3
Copy link
Contributor Author

radito3 commented Jun 23, 2021

Hi @dmikusa-pivotal,
I wrote some integration tests. Could you verify them?

@dmikusa
Copy link
Contributor

dmikusa commented Jun 24, 2021

I ran the unit & integration tests for this, and they passed. I'm going to merge this. Thanks for the contribution!

@dmikusa dmikusa merged commit b230acf into cloudfoundry:main Jun 24, 2021
dmikusa pushed a commit that referenced this pull request Aug 20, 2021
* Add support for V3 Stacks
* Add integration test for Stacks V3
@radito3 radito3 deleted the v3-stacks branch January 6, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client triaged Initial triage of issue has been performed

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Missing V3 Stacks API

2 participants