Add support for V3 Roles #1079
Add support for V3 Roles #1079
Conversation
|
|
|
Thanks for the PR @radito3! I did a quick check through the code and the only thing that jumped out at me is we're naming all new V3 endpoints with their version, e.g. RolesV3. If you could update that, and sign the EasyCLA, I should be able to get this merged quickly. |
|
@twoseat Thanks for the comment! I renamed the appropriate classes from |
twoseat
left a comment
twoseat
left a comment
There was a problem hiding this comment.
Looks great with just a couple of issues. Once updated I'll put some integration tests behind it, which almost always reveal a problem (generally a gap between the API and the documentation, not us!)
| import org.cloudfoundry.client.v3.ToOneRelationship; | ||
| import org.junit.Test; | ||
|
|
||
| public class CreateRoleRequestTest { |
There was a problem hiding this comment.
Please add a couple of tests for the @Value.Check in the request.
| import static org.cloudfoundry.operations.applications.ApplicationHealthCheck.PORT; | ||
| import static org.junit.Assume.assumeTrue; | ||
|
|
||
| @org.junit.Ignore |
There was a problem hiding this comment.
Oops, my bad. Will remove it
|
@twoseat Could you take another look? |
2 participants
Fixes #1078