Protect Blocking API #1068
Merged
Protect Blocking API #1068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the UaaSigningKeyResolver must use .block() in order to implement a blocking interface. Use of this API within a non-blocking thread is illegal since Reactor 3.2. A .scheduleOn() call, moving the execution to an elastic scheduler was in place but turned out to be the wrong implementation. This change updates the protection to a .publishOn() to move it out of a non-blocking thread at the right time. Signed-off-by: Ben Hale <[email protected]>
twoseat
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
UaaSigningKeyResolvermust use.block()in order to implement a blocking interface. Use of this API within a non-blocking thread is illegal since Reactor 3.2. A.scheduleOn()call, moving the execution to an elasticscheduler was in place but turned out to be the wrong implementation. This change updates the protection to a
.publishOn()to move it out of a non-blocking thread at the right time.