-
Notifications
You must be signed in to change notification settings - Fork 320
Add Log Cache client #1053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Log Cache client #1053
Conversation
integration-test/src/test/java/org/cloudfoundry/logcache/v1/LogCacheTest.java
Outdated
Show resolved
Hide resolved
integration-test/src/test/java/org/cloudfoundry/ApplicationUtils.java
Outdated
Show resolved
Hide resolved
...ent-reactor/src/main/java/org/cloudfoundry/reactor/logcache/v1/ReactorLogCacheEndpoints.java
Show resolved
Hide resolved
...ent-reactor/src/main/java/org/cloudfoundry/reactor/logcache/v1/ReactorLogCacheEndpoints.java
Outdated
Show resolved
Hide resolved
cloudfoundry-client/src/main/java/org/cloudfoundry/logcache/v1/LogCacheClient.java
Show resolved
Hide resolved
cloudfoundry-client/src/test/java/org/cloudfoundry/logcache/v1/MetadataTest.java
Outdated
Show resolved
Hide resolved
integration-test/src/test/java/org/cloudfoundry/logcache/v1/LogCacheTest.java
Outdated
Show resolved
Hide resolved
integration-test/src/test/java/org/cloudfoundry/logcache/v1/LogCacheTest.java
Outdated
Show resolved
Hide resolved
twoseat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the possible double-review, I was switching machines!
|
@twoseat I've made all the changes you suggested. Thanks for being so thorough. Let me know if you're still seeing intermittent integration test failures. I've run the integration tests 4 or 5 times against my test environment today and haven't seen any Log Cache test failures. |
|
Picked this up again (sorry for the delay, wrestling with a PR!) and I'm afraid I am still seeing intermittent failures on
I'll keep probing. |
19340f0 to
855da92
Compare
|
@twoseat All the tests are passing now. |
twoseat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things and I think this is ready to go! Excellent work, made all the better by it not having to be my work.
...ent-reactor/src/main/java/org/cloudfoundry/reactor/logcache/v1/ReactorLogCacheEndpoints.java
Outdated
Show resolved
Hide resolved
cloudfoundry-client/src/main/java/org/cloudfoundry/logcache/v1/EnvelopeType.java
Show resolved
Hide resolved
cloudfoundry-client/src/main/java/org/cloudfoundry/logcache/v1/LogType.java
Show resolved
Hide resolved
cloudfoundry-client/src/test/java/org/cloudfoundry/logcache/v1/InfoRequestTest.java
Show resolved
Hide resolved
integration-test/src/test/java/org/cloudfoundry/ApplicationUtils.java
Outdated
Show resolved
Hide resolved
integration-test/src/test/java/org/cloudfoundry/ApplicationUtils.java
Outdated
Show resolved
Hide resolved
855da92 to
585e4d2
Compare
585e4d2 to
49c3af8
Compare
|
Hi @mheath - I ran the integration tests on this prior to merging and found an issue. While the tests report that they've run fine, the overall log for the run contains multiple references to resource leaks:
I've checked a few similar-ish existing tests and don't see the same problem. It's entirely possible that you're just poking an issue in existing code, but if so I haven't been able to track that down. Let me know how you get on recreating it! Edit: Note that we run with |
|
I may be missing something needed to clean things up properly. Let me double check. |
94f2979 to
8839d18
Compare
|
This depends on #1084 for the tests to run without any |
|
Closed in 5fc354b |

This PR adds:
The integration tests have been modified to: