Add a pkcs11key_stub for build tools.#226
Merged
lziest merged 1 commit intocloudflare:masterfrom Jun 1, 2015
Merged
Conversation
Contributor
|
Golint gives the following: Can you adjust the comment? |
Contributor
Author
|
Made the requested change, but Travis is still failing. I can't figure out the Travis output: any suggestions? |
Contributor
|
Looks like some stale testdata, @lziest is taking a look. |
Contributor
|
please rebase on master to fix tests (addressed by #228) |
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
lziest
added a commit
that referenced
this pull request
Jun 1, 2015
Add a pkcs11key_stub for build tools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Boulder, we're using godep to vendorize dependencies. I'm working on a change to include the pkcs11 dependencies as well. This requires a patched version of godep to support tags (tools/godep#117).
Unfortunately, godep gets confused and gives the error:
This error is simply fixed by adding this file.