Skip to content

LITE-31369: Fix AsyncConnectClient ignoring environment proxies#82

Merged
qarlosh merged 1 commit intomasterfrom
LITE-31369_fix_proxy_issue
Nov 20, 2024
Merged

LITE-31369: Fix AsyncConnectClient ignoring environment proxies#82
qarlosh merged 1 commit intomasterfrom
LITE-31369_fix_proxy_issue

Conversation

@qarlosh
Copy link

@qarlosh qarlosh commented Nov 15, 2024

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Carlos Herrero seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sonarqubecloud
Copy link

httpx.AsyncHTTPTransport(verify=_SSL_CONTEXT),
),
)
transport = _ASYNC_TRANSPORTS.get(self.endpoint)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also fixed how transports are reused, because a new transport object was created every time even if the existing one for the endpoint was used.

@r-s11v r-s11v self-requested a review November 19, 2024 15:32
@qarlosh qarlosh merged commit dbbb038 into master Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants