Add unit tests for coriolisclient main modules #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cristi1324
force-pushed
the
add_unit_tests
branch
from
b3c5cc1 to
aa80769
Compare
Dany9966
requested changes
Nov 22, 2024
| return NotImplemented | ||
| # two resources of different types are not equal | ||
| if not isinstance(other, self.__class__): | ||
| return False |
Contributor
There was a problem hiding this comment.
Please add this code back. This equality is important when comparing resources of different types. (ex. Replica and Migration, these will not be equal, even if their info are the same).
Contributor
There was a problem hiding this comment.
Also, please add this case when testing this method.
Cristi1324
force-pushed
the
add_unit_tests
branch
3 times, most recently
from
1d9cc4f to
a930963
Compare
Dany9966
reviewed
Nov 27, 2024
coriolisclient/tests/test_base.py
Outdated
| """Defines base class for all tests.""" | ||
|
|
||
| from oslotest import base | ||
| from oslotest import mock_fixture |
Contributor
There was a problem hiding this comment.
Please move this import into the group below
Cristi1324
force-pushed
the
add_unit_tests
branch
from
a930963 to
7b7d5cf
Compare
Dany9966
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for coriolisclient main modules.