Add unit tests for coriolisclient.v1.* modules
#86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dany9966
requested changes
Nov 21, 2024
Contributor
Dany9966
left a comment
Dany9966
left a comment
There was a problem hiding this comment.
Mostly unnecessary mocks. Please fix
Comment on lines
29
to
30
| @mock.patch.object(common, 'encode_base64_param') | ||
| @mock.patch.object(base, 'getid') |
Contributor
There was a problem hiding this comment.
These don't need mocking. I'd prefer real test examples please
| @mock.patch.object(endpoint_destination_options. | ||
| EndpointDestinationOptionsManager, '_list') | ||
| @mock.patch.object(common, 'encode_base64_param') | ||
| @mock.patch.object(base, 'getid') |
| @mock.patch.object(endpoint_instances.EndpointInstanceManager, '_list') | ||
| @mock.patch.object(urlparse, 'urlencode') | ||
| @mock.patch.object(common, 'encode_base64_param') | ||
| @mock.patch.object(base, 'getid') |
|
|
||
| @mock.patch.object(endpoint_instances.EndpointInstanceManager, '_get') | ||
| @mock.patch.object(common, 'encode_base64_param') | ||
| @mock.patch.object(base, 'getid') |
|
|
||
| @mock.patch.object(endpoint_networks.EndpointNetworkManager, '_list') | ||
| @mock.patch.object(common, 'encode_base64_param') | ||
| @mock.patch.object(base, 'getid') |
| mock_post.assert_called_once_with( | ||
| '/endpoints', expected_data, 'endpoint') | ||
|
|
||
| @mock.patch.object(base, 'getid') |
| mock_put.assert_called_once_with( | ||
| '/endpoints/sentinel.id', expected_data, 'endpoint') | ||
|
|
||
| @mock.patch.object(base, 'getid') |
| ) | ||
| mock_delete.assert_called_once_with('/endpoints/sentinel.id') | ||
|
|
||
| @mock.patch.object(base, 'getid') |
Comment on lines
172
to
173
| @mock.patch.object(endpoints.EndpointManager, '_get_endpoint_id_for_name') | ||
| @mock.patch.object(utils, 'validate_uuid_string') |
| ) | ||
|
|
||
| @mock.patch.object(endpoints.EndpointManager, 'list') | ||
| @mock.patch.object(utils, 'validate_uuid_string') |
Cristi1324
force-pushed
the
add_v1_unit_tests
branch
from
b4af9d6 to
42e9086
Compare
Dany9966
requested changes
Nov 27, 2024
Comment on lines
36
to
37
| {"env": "mock_env"}, | ||
| ["option1", "option2"] |
Contributor
There was a problem hiding this comment.
Please add keyword arg names
Suggested change
| {"env": "mock_env"}, | |
| ["option1", "option2"] | |
| environment={"env": "mock_env"}, | |
| option_names=["option1", "option2"] |
Comment on lines
32
to
33
| {"env": "mock_env"}, | ||
| ["option1", "option2"] |
| result = self.endpoint.get( | ||
| mock_endpoint, | ||
| "mock_id", | ||
| {"env": "mock_env"}, |
Contributor
There was a problem hiding this comment.
Same as above
Suggested change
| {"env": "mock_env"}, | |
| env={"env": "mock_env"}, |
| ValueError, | ||
| self.endpoint.get, | ||
| mock_endpoint, | ||
| "mock_env", |
Contributor
There was a problem hiding this comment.
Suggested change
| "mock_env", | |
| "mock_instance_id", |
|
|
||
| result = self.endpoint.list( | ||
| mock_endpoint, | ||
| {"env": "mock_env"}, |
Comment on lines
36
to
37
| {"env": "mock_env"}, | ||
| ["option1", "option2"] |
Comment on lines
32
to
33
| {"env": "mock_env"}, | ||
| ["option1", "option2"] |
|
|
||
| result = self.endpoint.list( | ||
| mock_endpoint, | ||
| {"env": "mock_env"} |
|
|
||
| result = self.endpoint.get_default( | ||
| mock_endpoint, | ||
| {"env": "mock_env"}, |
| } | ||
| ) | ||
|
|
||
| def test_flavor_name(self): |
Contributor
There was a problem hiding this comment.
:)
Suggested change
| def test_flavor_name(self): | |
| def test_connection_info(self): |
…l_options` module
Cristi1324
force-pushed
the
add_v1_unit_tests
branch
from
42e9086 to
c2c816b
Compare
Dany9966
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for
coriolisclient.v1.common...endpointsmodules.