Skip to content

Conversation

@thomasst
Copy link
Member

@thomasst thomasst commented Feb 27, 2024

  • This will retry on "execution not found" if the task also retries JobTimeoutError, i.e. is idempotent.
  • The "execution not found" error will be changed to a warning.

The only possible danger from this is that retries on this error would not count towards the retry counter since we don't have an execution, which might lead to too many retries at the first retry interval without a cap. I see this possibility as rare, and if we wanted to we could manually create a dummy execution.

@thomasst thomasst merged commit 8bffe61 into master Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants