Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
cloutiertyler
approved these changes
Feb 24, 2026
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
Very low risk because it only touches xtask-llm-benchmark
- map_or(false, ...) → is_some_and(...) in runner.rs and hashing.rs - repeat(..).take(n) → repeat_n(.., n) in templates.rs
- Add missing `dotenvy = "0.15"` dependency to Cargo.toml - Allow `clippy::type_complexity` and `clippy::enum_variant_names` at module level (benchmark tool, not library code) - Fix `map_or(false, ...)` → `is_some_and(...)`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
LLM benchmark updates for local development:
crates/bindings,crates/bindings-csharp,crates/bindings-typescript) instead of published packages, so the bench runs against local SDK changes.pnpmis not on PATH, the bench usesNODEJS_DIRto locatepnpmand prepends it to PATH for subprocesses.relative_to_workspace()intemplates.rsand removed noisyNODEJS_DIRlogging inpublishers.rs.docs/llms/llm-comparison-details.jsonanddocs/llms/llm-comparison-summary.json.API and ABI breaking changes
None.
Expected complexity level and risk
2 — Local-only changes to the benchmark tool. Templates now require local SDKs to be built (especially TypeScript:
pnpm buildincrates/bindings-typescript). No impact on published SDKs or runtime.Testing
cargo llm run --lang rust --modes docs --providers openaifrom repo rootpnpm buildincrates/bindings-typescriptfirstNODEJS_DIRifpnpmis not on PATH and run TypeScript benchmarks