C# smoketest for IQuery views#4391
Merged
clockwork-labs-bot merged 4 commits intomasterfrom Feb 27, 2026
Merged
Conversation
joshua-spacetime
added
release-2.0
bugfix
joshua-spacetime
changed the title
IQuery return type for C# views
Collaborator
Author
|
|
Collaborator
Author
|
Removing the |
joshua-spacetime
force-pushed
the
joshua/fix/query-builder-cs
branch
from
2b49db3 to
119b30d
Compare
joshua-spacetime
changed the title
IQuery return type for C# viewsIQuery views
joshua-spacetime
force-pushed
the
joshua/fix/query-builder-cs
branch
from
6e61697 to
bdbb95f
Compare
rekhoff
approved these changes
Feb 26, 2026
Contributor
rekhoff
left a comment
rekhoff
left a comment
There was a problem hiding this comment.
Looks good to me. I've not ran the test locally, but given that it's a CI test, if it passes there that is sufficient. The test itself seems extremely strait forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Updates Roslyn codegen to handleIQueryreturn type for views.IQuerywasn't recognized before this change, which meant.Build()was still required for query builder views.Note, we currently support the oldQueryreturn type which means we still support.Build(). I'm not sure if this was intended whenIQuerywas originally introduced, so I'm maintaining support for it until I can determine otherwise. cc @cloutiertyler.This is now a test only change.
This patch introduces scaffolding for defining and running C# module smoketests. It also adds a new C# smoketest for an
IQueryview.API and ABI breaking changes
None
Expected complexity level and risk
2
Testing
A testing only change.