Optimize TxData + DatabaseUpdate for fast construction#4138
Merged
Conversation
Centril
changed the title
TxData + DatabaseUpdate for fast construction
Centril
force-pushed
the
centri/table-reducer-name
branch
from
2c8cfc5 to
340667d
Compare
Centril
force-pushed
the
centril/restructure-tx-data
branch
from
01c7250 to
3cec6c0
Compare
gefjon
approved these changes
Jan 27, 2026
Centril
force-pushed
the
centril/restructure-tx-data
branch
from
3cec6c0 to
0ee6796
Compare
Centril
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
restructure `TxData` to store everything for a table together use `SmallHashMap` to optimize `TxData`
Centril
force-pushed
the
centril/restructure-tx-data
branch
from
0ee6796 to
b3c5fdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Rework
TxDatato:TxDataTableEntryrather than having several different maps.(TableId, TxDataTableEntry)takes up 64 bytes.{inserts, deletes}_for_tableto makeDeltaTxfaster.Rework
DatabaseUpdateto:DatabaseTableUpdateinlinefrom_writesprofit from the changes toTxData, avoiding the temporary hash map and allocating the necessary capacity from the start.API and ABI breaking changes
None
Expected complexity level and risk
3? Fairly simple changes, but in important places.
Testing
Existing tests are changed to match the changes to
TxData.