optimize datastore by using ty.layout.fixed more#4133
Merged
Conversation
Shubham8287
approved these changes
Jan 27, 2026
Centril
added a commit
that referenced
this pull request
Jan 27, 2026
# Description of Changes Exploit `(ty: RowTypeLayout).layout.fixed` to avoid some work involving var-len stuff: - skip `required_var_len_granules_for_row` for only-fixed-len layouts. - skip `write_large_blobs` for only-fixed-len layouts. - add a fast path in `has_space_for_row` for only-fixed-len layouts. This resulted in these methods disappearing in flamegraphs. # API and ABI breaking changes None # Expected complexity level and risk 2, core datastore, but fairly trivial. # Testing Covered by existing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Exploit
(ty: RowTypeLayout).layout.fixedto avoid some work involving var-len stuff:required_var_len_granules_for_rowfor only-fixed-len layouts.write_large_blobsfor only-fixed-len layouts.has_space_for_rowfor only-fixed-len layouts.This resulted in these methods disappearing in flamegraphs.
API and ABI breaking changes
None
Expected complexity level and risk
2, core datastore, but fairly trivial.
Testing
Covered by existing tests.