[1/3] RawModuleDefV10 definition and validation.#4098
Merged
Shubham8287 merged 14 commits intomasterfrom Jan 28, 2026
Merged
Conversation
gefjon
reviewed
Jan 22, 2026
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
I haven't looked at your validation logic yet, but I assume it's reasonably straightforward. The raw def format itself looks great, excellent work.
Shubham8287
force-pushed
the
shub/raw-defination
branch
from
011f101 to
d743fa7
Compare
gefjon
approved these changes
Jan 27, 2026
gefjon
reviewed
Jan 27, 2026
gefjon
approved these changes
Jan 27, 2026
Shubham8287
force-pushed
the
shub/raw-defination
branch
2 times, most recently
from
62e46ad to
860d600
Compare
Shubham8287
force-pushed
the
shub/raw-defination
branch
from
860d600 to
309d705
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 28, 2026
# Description of Changes Host side changes for Wasm to work with `RawModuleDefV10` along with prior versions. Based on ##4098 # API and ABI breaking changes NA # Expected complexity level and risk 1.5 # Testing Existing test will cover for any regression. Not yet functional for `RawModuleDefV10`, so can not be tested now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Patch:
crates/lib/src/db/raw_def/v10.rs- a definition as per https://github.com/clockworklabs/SpacetimeDBPrivate/issues/2412.RawModuleDefV9validation code to dedup some of the core validation logic, No functionality should change there.RawModuleDefV10.crates::schema::def::ModuleDef:raw_module_def_versionvisibilityfield to existingRedcuerDefandProcedureDefLot of code is duplicated from
RawModuleDefV9includng tests.API and ABI breaking changes
NA,
RawModuleDefV10is not yet exported by modules.Expected complexity level and risk
3? close analyses of structure is important to ensure future extensibility.
Testing
For code motion in
RawModuleDefV9validation: Existing unit tests seems to cover any functionality change.For
RawModuleDefV10: V9 test has been repeated with moreasserts to check onvisibility