Fixes basic issues using the basic-react template.#4017
Merged
Conversation
1 task
In StrictMode, React unmounts and remounts components synchronously to detect side effects. The previous cleanup would disconnect immediately, killing the in-flight WebSocket connection. Fix: defer disconnect with setTimeout(..., 0). Since StrictMode remounts happen in the same JavaScript task, the remount cancels the pending timeout, preserving the connection. Real unmounts proceed normally since no remount occurs to cancel the timeout.
The error now hints that the table may be private, helping users diagnose visibility issues.
cloutiertyler
force-pushed
the
tyler/claude-docs-2
branch
from
d1a9afc to
3c42af9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
For consistency with other CLI commands (publish, call, logs, sql), the database name is now a positional argument instead of a flag. The --database flag is deprecated but still works with a warning.
egormanga
reviewed
Jan 13, 2026
bfops
approved these changes
Jan 13, 2026
Collaborator
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
Well that seems like a headache to track down. Fix LGTM if it fixes something for you (well, once the CLI docs are fixed).
Contributor
Author
|
/update-llm-benchmark |
Collaborator
LLM Benchmark Results (ci-quickfix)
Generated at: 2026-01-13T16:50:13.733Z |
Collaborator
|
re-running failed testsuite |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kistz
pushed a commit
to kistz/SpacetimeDB
that referenced
this pull request
Jan 13, 2026
# Description of Changes - Made spacetime dev <database> a positional argument and deprecated --database - Fixed double connection in React SDK - Added a more descriptive error message to unresolved table name. # API and ABI breaking changes Deprecates `--database`. Still works, but it prints with a warning. # Expected complexity level and risk 2 # Testing - [x] I have tested that the double render fix works in React --------- Co-authored-by: clockwork-labs-bot <clockwork-labs-bot@users.noreply.github.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
API and ABI breaking changes
Deprecates
--database. Still works, but it prints with a warning.Expected complexity level and risk
2
Testing