Merged
Conversation
Collaborator
joshua-spacetime
left a comment
There was a problem hiding this comment.
Can we add some end-to-end tests?
Contributor
Author
Added end-to-end coverage in |
Collaborator
joshua-spacetime
left a comment
There was a problem hiding this comment.
Looks great. Only a few small remaining requests/questions.
1 task
…d NuGet packages
726269f to
f415652
Compare
joshua-spacetime
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR implements the C# client-side typed query builder, as assigned in #3759.
Key pieces:
sdks/csharp/src/QueryBuilder.cs):Query(wraps the generated SQL string)Table<TRow, TCols, TIxCols>(entry point forAll()/Where(...))Col<TRow, TValue>andIxCol<TRow, TValue>(typed column references)BoolExpr(typed boolean expression composition)SqlFormat)Join(...)withWhereLeft(...)/WhereRight(...)LeftSemijoin(...)/RightSemijoin(...)withWhere(...)chainingcrates/codegen/src/csharp.rs) to generate:*Colsand*IxColshelper classes used by the typed query builder.QueryBuilderwith aFromaccessor for each table/view, producingTable<...>values.TypedSubscriptionBuilderwhich collectsQuery<TRow>.Sqlvalues and calls the existing subscription API.AddQuery(Func<QueryBuilder, Query> build)entry point offSubscriptionBuilder, mirroring the proposal’s Rust API.*Cols/*IxColshelpers are now named after the table/view accessor name (PascalCase) instead of the row type, since multiple tables/views can share the same row type (e.g. alias tables / views returning an existing product type).Cols/IxColsoff the public surface:Table.ColsandTable.IxColsare internal, so consumers only access columns via theWhere(...)/join predicate lambdas.C# usage examples (mirroring the proposal’s Rust examples)
WHEREfilters and boolean compositionAPI and ABI breaking changes
None.
Expected complexity level and risk
2 - Low to moderate
Testing
dotnet test sdks/csharp/tests~/tests.csproj -c Releasesdks/csharp/tests~/QueryBuilderTests.cs) validating:Identity/ConnectionId/Uuidhex literals;U128integer literal)And/Or/Not)Where(...)overloads includingIxCols-based predicates