Fixes #3240, perf of indexing many rows with same key#3971
Merged
Conversation
Shubham8287
approved these changes
Jan 8, 2026
Centril
force-pushed
the
centril/fix-3240-index-many-same-key
branch
from
78bce4b to
cd45c73
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
# Description of Changes Fixes #3240. Non-unique indices are now backed by a type `SameKeyEntry` which holds the `RowPointer`s for the same key. When these `RowPointer`s exceed 4KiB (512 entries), the data structure switches from using an array list to a hash set. # API and ABI breaking changes None # Expected complexity level and risk 2? # Testing Covered by existing tests, though more test will come in future PRs.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
gefjon
approved these changes
Jan 8, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Centril
force-pushed
the
centril/fix-3240-index-many-same-key
branch
from
b0a8b56 to
299a8d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #3240.
Non-unique indices are now backed by a type
SameKeyEntrywhich holds theRowPointers for the same key.When these
RowPointers exceed 4KiB (512 entries), the data structure switches from using an array list to a hash set.API and ABI breaking changes
None
Expected complexity level and risk
2?
Testing
Covered by existing tests, though more test will come in future PRs.