[TS] Implement de/serialization as a tree of closures#3957
Merged
coolreader18 merged 7 commits intomasterfrom Feb 3, 2026
Merged
[TS] Implement de/serialization as a tree of closures#3957coolreader18 merged 7 commits intomasterfrom
coolreader18 merged 7 commits intomasterfrom
Conversation
Collaborator
Author
|
Requested @gefjon's review since they expressed familiarity with the strategy. |
coolreader18
force-pushed
the
noa/optimize-ts-serde
branch
6 times, most recently
from
ed9c6bb to
03d3f82
Compare
bfops
added
release-any
coolreader18
force-pushed
the
noa/optimize-ts-serde
branch
3 times, most recently
from
775375b to
0ff7251
Compare
gefjon
reviewed
Jan 21, 2026
coolreader18
force-pushed
the
noa/optimize-ts-serde
branch
7 times, most recently
from
53feb8b to
d1734bf
Compare
coolreader18
force-pushed
the
noa/optimize-ts-serde
branch
from
d1734bf to
a614fdc
Compare
gefjon
approved these changes
Feb 2, 2026
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
This looks great, thanks!
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 2, 2026
# Description of Changes This should optimize better than walking the AlgebraicType tree on every call. I'll do some profiling to confirm, but I am already using it in my performance experiments. # Expected complexity level and risk 2 - fully rewrites the bsatn encoder/decoder, but it's a fairly simple format. # Testing - [x] Automated testing - [x] Profiling
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This should optimize better than walking the AlgebraicType tree on every call. I'll do some profiling to confirm, but I am already using it in my performance experiments.
Expected complexity level and risk
2 - fully rewrites the bsatn encoder/decoder, but it's a fairly simple format.
Testing