Handle unknown transactions without erroring.#3858
Merged
Conversation
Contributor
|
Thanks for the fix! Hoping we’ll get a 1.12.0 or similar before the end of the year that includes this change 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Don't throw an error if there is no
reducerInfo. The code was previously trying to handle the case of an unknown reducer, but was effectively asserting that the reducerInfo existed too soon.Now we should be fine handling a transaction, even if we can't determine reducer information for it.
Expected complexity level and risk
Testing
I tested this by running the quickstart chat app, and using the CLI to delete rows (via
spacetime sql). Before this change, the client errors, but now it handles it correctly.I also tested with the repro in #3817