Skip to content

Update typescript package size limits#3854

Merged
jdetter merged 2 commits intomasterfrom
jdetter/update-typescript-package-limits
Dec 9, 2025
Merged

Update typescript package size limits#3854
jdetter merged 2 commits intomasterfrom
jdetter/update-typescript-package-limits

Conversation

@jdetter
Copy link
Collaborator

@jdetter jdetter commented Dec 8, 2025

Description of Changes

Updated package sizes from a failed release dry-run: https://github.com/clockworklabs/SpacetimeDBPrivate/actions/runs/20045893743/job/57491806595

API and ABI breaking changes

None

Expected complexity level and risk

1 - this is just a release fix

Testing

I have not tested this, it is a trivial change.

@jdetter jdetter requested a review from JulienLavocat December 8, 2025 23:28
@jdetter jdetter marked this pull request as ready for review December 8, 2025 23:28
@JulienLavocat
Copy link
Contributor

I am starting to be slightly concerned by how frequently we need to make this type of adjustment.
Also, if I remember correctly, this release includes a fix that replaces an SDK dependency with our own implementation. Shouldn’t that have reduced the bundle size?

@jdetter
Copy link
Collaborator Author

jdetter commented Dec 8, 2025

I am starting to be slightly concerned by how frequently we need to make this type of adjustment. Also, if I remember correctly, this release includes a fix that replaces an SDK dependency with our own implementation. Shouldn’t that have reduced the bundle size?

I'm not sure, I haven't been keep track of the typescript changes for this release - does anything seem wrong here?

@jdetter jdetter enabled auto-merge December 8, 2025 23:40
@jdetter jdetter added this pull request to the merge queue Dec 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2025
@jdetter jdetter enabled auto-merge December 9, 2025 10:18
@jdetter jdetter added this pull request to the merge queue Dec 9, 2025
Merged via the queue into master with commit 7e367b3 Dec 9, 2025
25 of 26 checks passed
jdetter added a commit that referenced this pull request Dec 9, 2025
# Description of Changes

<!-- Please describe your change, mention any related tickets, and so on
here. -->

Updated package sizes from a failed release dry-run:
https://github.com/clockworklabs/SpacetimeDBPrivate/actions/runs/20045893743/job/57491806595

# API and ABI breaking changes

<!-- If this is an API or ABI breaking change, please apply the
corresponding GitHub label. -->

None

# Expected complexity level and risk

1 - this is just a release fix

<!--
How complicated do you think these changes are? Grade on a scale from 1
to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex
change.

This complexity rating applies not only to the complexity apparent in
the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning
ways. -->

# Testing

<!-- Describe any testing you've done, and any testing you'd like your
reviewers to do,
so that you're confident that all the changes work as expected! -->

I have not tested this, it is a trivial change.
jdetter added a commit that referenced this pull request Dec 9, 2025
# Description of Changes

<!-- Please describe your change, mention any related tickets, and so on
here. -->

Updated package sizes from a failed release dry-run:
https://github.com/clockworklabs/SpacetimeDBPrivate/actions/runs/20045893743/job/57491806595

# API and ABI breaking changes

<!-- If this is an API or ABI breaking change, please apply the
corresponding GitHub label. -->

None

# Expected complexity level and risk

1 - this is just a release fix

<!--
How complicated do you think these changes are? Grade on a scale from 1
to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex
change.

This complexity rating applies not only to the complexity apparent in
the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning
ways. -->

# Testing

<!-- Describe any testing you've done, and any testing you'd like your
reviewers to do,
so that you're confident that all the changes work as expected! -->

I have not tested this, it is a trivial change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants