[TS] Implement TextEncoder/TextDecoder with native code#3800
Merged
coolreader18 merged 3 commits intomasterfrom Dec 4, 2025
Merged
[TS] Implement TextEncoder/TextDecoder with native code#3800coolreader18 merged 3 commits intomasterfrom
coolreader18 merged 3 commits intomasterfrom
Conversation
coolreader18
force-pushed
the
noa/native-js-utf8
branch
from
964ef3c to
2c37ab6
Compare
coolreader18
force-pushed
the
noa/native-js-utf8
branch
from
2c37ab6 to
3f7e54c
Compare
Centril
reviewed
Dec 2, 2025
Centril
approved these changes
Dec 4, 2025
Collaborator
Author
|
Internal tests are only due to this branch not being based on latest master. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 12, 2026
# Description of Changes Hasn't been needed in months (since #3800), it'd be nice to get it in to 2.0 if possible. # Expected complexity level and risk 1 # Testing - [x] Builds successfully - [ ] <!-- maybe a test you want a reviewer to do, so they can check it off when they're satisfied. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This implements (a subset of) the TextEncoder/TextDecoder web APIs using native functions to do the actual
Uint8Array <-> Stringconversion. This should be a good bit faster than thefast-text-encodingpackage.Expected complexity level and risk
2 - this introduces new kinds of JS code and host calls to the v8 host, but they're pretty well encapsulated.
Testing
fast-text-encodingpolyfill we pull in only takes effect if the classes don't already exist, so the smoketests passing means it works.