[Rust] Module-side query builder types#3797
Merged
Shubham8287 merged 18 commits intomasterfrom Dec 4, 2025
Merged
Conversation
3b7045c to
abf70dd
Compare
c5c94ea to
f00dea7
Compare
f00dea7 to
fe0ff01
Compare
Shubham8287
commented
Dec 2, 2025
Contributor
Author
|
Changes since last review:
|
joshua-spacetime
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Implements a query builder for rust modules according to the spec.
Look at the tests in
query_builder.rs.TODO: Extend return type for views to include
Queryand update the#[table]macro to generate query builder bindings.API and ABI breaking changes
This is an additive change. Current modules do not need to be updated unless they wish to use the query builder.
Expected complexity level and risk
1.5, Will appreciate comments to better structure code.
Testing
[x]: unit tests.
I have also done type safety checks manually from module.