Revert "Procedures: fix scheduling (#3704)"#3774
Merged
Conversation
This reverts commit b2e37e8.
gefjon
approved these changes
Nov 26, 2025
Centril
approved these changes
Nov 26, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2025
# Description of Changes We've been unable to get scheduled procedures into the initial release of procedures due to a nondeterministic hang in some of our tests which we don't have time to debug. As such, this commit disables scheduled procedures by: - Changing the `RawModuleDevV9` validator to reject scheduled procedures. - Changing the Rust bindings library's typechecking magic so that scheduled table annotations referencing procedures will cause a type error. - Removes some docs from the Rust bindings library which reference scheduled procedures. # API and ABI breaking changes N/a # Expected complexity level and risk 1 # Testing Automated tests should be sufficient. Prior to merging #3774 , CI for this branch merged with master failed in the intended way: modules which attempted to define scheduled procedures failed to typecheck.
coolreader18
added a commit
that referenced
this pull request
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b2e37e8.
Description of Changes
Reverts #3704 which I'm pretty sure contains some sort of bug which is causing the smoketests to hang.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing