Merged
Conversation
coolreader18
force-pushed
the
noa/ts-procedures
branch
from
acd46ea to
6e2ece6
Compare
coolreader18
force-pushed
the
noa/ts-http
branch
from
7495076 to
41669b0
Compare
gefjon
approved these changes
Nov 24, 2025
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
I don't feel comfortable enough with either our V8 internals or TypeScript bindings to do an in-depth review, but I like the API design here. I appreciate the cross-language consistency of keeping HTTP-related methods in ctx.http, and also the similarity between your fetch method and the browser env's fetch function.
Centril
approved these changes
Nov 24, 2025
Contributor
Centril
left a comment
Centril
left a comment
There was a problem hiding this comment.
This looks mostly good. I'd like to request some changes below though before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Provides a fetch-alike API on
ctx.http. I guess it could just bectx.fetch()instead ofctx.http.fetch(), but I'm not sure if that's a good idea.Expected complexity level and risk
2
Testing