Bump hashbrown, foldhash; Fix some compile errors in master#3722
Merged
Bump hashbrown, foldhash; Fix some compile errors in master#3722
Conversation
Centril
force-pushed
the
centril/deps-house-keeping
branch
from
d8d0445 to
46ca15e
Compare
gefjon
reviewed
Nov 21, 2025
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
The PR also bump hashbrown to 0.16.1 and foldhash to 0.2.0.
Why?
Contributor
Author
Well foldhash 0.2.0 had some performance improvements and hashbrown 0.16.x is already in Cargo.lock (e.g., indexmap). |
Contributor
That's reasonable. In the future, please put that sort of reasoning for dependency bumps in the PR description. |
gefjon
approved these changes
Nov 24, 2025
Centril
force-pushed
the
centril/deps-house-keeping
branch
from
46ca15e to
3d6a7fe
Compare
Centril
force-pushed
the
centril/deps-house-keeping
branch
from
3d6a7fe to
cb56bdc
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
There were mentions of
hashbrownin the repo that did not go throughspacetimedb_data_structures::map.This caused compile errors on master when running certain tests locally.
These have been replaced with the proper imports.
The PR also bump hashbrown to 0.16.1 and foldhash to 0.2.0.
API and ABI breaking changes
None
Expected complexity level and risk
2
Testing
Covered by existing tests.