HTTP followup: remove http dep from spacetimedb_lib#3719
Merged
coolreader18 merged 4 commits intomasterfrom Nov 21, 2025
Merged
HTTP followup: remove http dep from spacetimedb_lib#3719coolreader18 merged 4 commits intomasterfrom
http dep from spacetimedb_lib#3719coolreader18 merged 4 commits intomasterfrom
Conversation
coolreader18
force-pushed
the
noa/http-followup
branch
from
c625b09 to
d48919f
Compare
gefjon
approved these changes
Nov 20, 2025
coolreader18
changed the title
http dep from spacetimedb_lib
coolreader18
force-pushed
the
noa/http-followup
branch
from
ff04008 to
f60d039
Compare
coolreader18
force-pushed
the
noa/http-followup
branch
from
f60d039 to
911666c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Follow up to #3684. Moves
ErrorandTimeoutout of lib, so that we don't have to implementSpacetimeTypefor them, and then removes the http dependency altogether, so thatlibcan be leaner. I also got rid of the separateHttpValuetype, since it only really exists to mirror thehttpcrate and typescript won't make use of it.Expected complexity level and risk
1
Testing
n/a - just code movement.