Adds flag to publish to allow clearing on migration conflict.#3601
Merged
cloutiertyler merged 11 commits intomasterfrom Nov 19, 2025
Merged
Adds flag to publish to allow clearing on migration conflict.#3601cloutiertyler merged 11 commits intomasterfrom
cloutiertyler merged 11 commits intomasterfrom
Conversation
bfops
reviewed
Nov 8, 2025
bfops
reviewed
Nov 8, 2025
bfops
reviewed
Nov 8, 2025
bfops
reviewed
Nov 8, 2025
bfops
reviewed
Nov 8, 2025
bfops
approved these changes
Nov 8, 2025
Collaborator
bfops
left a comment
There was a problem hiding this comment.
my code-owned changes LGTM, but left several small comments
Contributor
Author
|
Fixed all the comments! |
Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com> Signed-off-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com>
18e60dc to
fab73cc
Compare
bfops
reviewed
Nov 11, 2025
Collaborator
|
Smoketests failing due to: |
Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com> Signed-off-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com>
Collaborator
|
Disabling auto-merge since I was only approving my code-owned changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR modifies the
--delete-dataflag onspacetime publishand adds the--delete-dataflag onspacetime dev.In particular instead of
--delete-databeing a boolean, it is now a an enum:always-> corresponds to the old value oftruenever-> corresponds to the old value offalseon-conflict-> clears the database, but only if publishing would have required a manual migrationThis flag does NOT change any behavior about prompting users to confirm if they want to delete the data. Users will still be prompted to confirm UNLESS they pass the separate
--yesflag.spacetime devgets the same--delete-dataflag. The default value ofneveris equivalent to the existing behavior.spacetime devcontinues to publish with--yesjust as before. This behavior is unchanged.API and ABI breaking changes
Adds the flags specified above. This is NOT a breaking change to the CLI. Passing
--delete-datais the equivalent of--delete-data=always.This IS technically a breaking change to the
pre_publishroute. As far as I'm aware this is only used by our CLI however.Expected complexity level and risk
2, Very small change, but if we get it wrong users could accidentally lose data. I would ask reviewers to think about ways that users might accidentally pass
--delete-data --yes.Testing