Dockerfile fails more cleanly if .git is a submodule#3591
Merged
Conversation
bfops
force-pushed
the
bfops/fix-dockerfile
branch
from
85b9faf to
e7fe995
Compare
bfops
changed the title
Dockerfile fails more cleanly if .git is a submodule
cloutiertyler
approved these changes
Nov 6, 2025
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
Seems reasonable and well commented.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Our
DockerfilerunsCOPY . .. If we're in a submodule rather than a "full" git repo, that causes.gitto be a in a weird state inside the docker container, where it thinks it's in a submodule even though the parent directory context has been lost.This PR just adds a clear error message early in the process, because this has bitten us a few times.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
docker buildthis from within a submodule.