Merged
Conversation
coolreader18
force-pushed
the
noa/ts-views
branch
2 times, most recently
from
bf81d07 to
61c21e3
Compare
coolreader18
force-pushed
the
noa/ts-views
branch
2 times, most recently
from
ab7e5d0 to
9d0e017
Compare
coolreader18
force-pushed
the
noa/ts-views
branch
from
9d0e017 to
d220b57
Compare
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
This generally looks good to me. I took a closer look at the TypeScript side and it seems fine to me, indeed I've made some of the same changes in #3559.
I would like to do additional testing though. I think we should at least add views and all the options and stuff to modules/module-test-ts
Centril
approved these changes
Nov 7, 2025
Contributor
Centril
left a comment
Centril
left a comment
There was a problem hiding this comment.
The host side looks good. I just have some minor suggestions.
Collaborator
joshua-spacetime
left a comment
joshua-spacetime
left a comment
There was a problem hiding this comment.
@coolreader18 Could you add this view to module-test-ts for the ensure_same_schema tests.
coolreader18
force-pushed
the
noa/ts-views
branch
from
d220b57 to
88dec94
Compare
coolreader18
force-pushed
the
noa/ts-views
branch
from
88dec94 to
dbefed8
Compare
coolreader18
force-pushed
the
noa/ts-views
branch
from
dbefed8 to
800e627
Compare
coolreader18
force-pushed
the
noa/ts-views
branch
from
800e627 to
1703880
Compare
Collaborator
|
@coolreader18 Could you also disable passing parameters? We can re-enable once we have sql support for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Currently need changes from both #3548 and #3527, and the latter is merged into master but the former isn't rebased on top of it. so we stay silly for the moment
I'd like to pull out my first commit into its own PR, but that's not really possible until #3548 rebases onto master.
Expected complexity level and risk
2 - pretty straightforward translation of the wasm/Rust view implementation to typescript.
Testing