Merged
Conversation
joshua-spacetime
force-pushed
the
joshua/client-bindings-for-views
branch
from
5fce21c to
f9858af
Compare
joshua-spacetime
force-pushed
the
joshua/call-views-from-sql
branch
2 times, most recently
from
eb7a1e7 to
f5bbcb0
Compare
Shubham8287
reviewed
Nov 4, 2025
Contributor
Shubham8287
left a comment
Shubham8287
left a comment
There was a problem hiding this comment.
Is it parsing the input arguments to view tables? I can't find that logic though I also do not understand related code much yet.
Shubham8287
approved these changes
Nov 4, 2025
Contributor
Shubham8287
left a comment
Shubham8287
left a comment
There was a problem hiding this comment.
LGTM, given that we have separate ticket for parsing input params for Views.
joshua-spacetime
force-pushed
the
joshua/call-views-from-sql
branch
from
5049571 to
400b935
Compare
joshua-spacetime
force-pushed
the
joshua/call-views-from-sql
branch
5 times, most recently
from
ccf7d6c to
346ada3
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
joshua-spacetime
force-pushed
the
joshua/call-views-from-sql
branch
from
346ada3 to
9d4400b
Compare
joshua-spacetime
force-pushed
the
joshua/call-views-from-sql
branch
from
9d4400b to
523d6a1
Compare
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Not many changes were required for the query compiler to be able to resolve views. This is because the query engine can always assume a view is materialized and therefore has a backing table. So from the perspective of the query engine, a view is just another table with one small caveat: The physical table in the datastore has two internal metadata columns -
senderandarg_id. These columns are not user facing and so should be hidden from name resolution/type checking.API and ABI breaking changes
None
Expected complexity level and risk
1.5
Testing